This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mips and frv testsuite failures after plugin patch


On 25/10/2010 07:22, Alan Modra wrote:

>>   ... oooooor, I could make _bfd_delete_bfd decrement the _bfd_id_counter when
>> it notices we're deleting the last-created BFD?  Hmm, I like that idea.  It
>> seems a lot simpler.  There shouldn't be any problem with the notion of
>> speculatively allocating an ID and then recycling it immediately (at any rate,
>> before any other IDs are allocated).
>
> Or this.
>
> bfd/
> 	* opncls.c (_bfd_id_counter): Rename to bfd_id_counter.
> 	(bfd_reserved_id_counter, bfd_use_reserved_id): New vars.
> 	(_bfd_new_bfd): Use negative id when bfd_use_reserved_id.
> 	(bfd_create): Doc fix.
> 	* bfd-in2.h: Regenerate.
> ld/
> 	* plugin.c (plugin_get_ir_dummy_bfd): Set bfd_use_reserved_id.
> 	Formatting.

  Counting down from the other end, yeah, I considered that too; it's probably
even more reliable.  It looks like it ought to work.

  On the other hand, your patch didn't make any difference when I tried it
against cross-frv-elf on HEAD: no change in the test results at all.

  On the third hand, it appears to me that those "FRV TLS relocs" failures
were all pre-existing before my patch.  I wound back a repository to

> commit 88a19d49326ad9b004d2d653fe5cc4f225b266e5
> Author: Alan Modra <amodra
> Date:   Wed Oct 13 23:00:05 2010 +0000
>
>     daily update

... here, and it still gives FAILs for all those tests.  So that explains why
patching bfd doesn't fix them for me, but leaves open the mystery of why
you've only just started seeing them.

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]