This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Properly align static TLS segments on Solaris 2
Alan Modra <amodra@gmail.com> writes:
> On Mon, Oct 18, 2010 at 09:10:30PM +0200, Rainer Orth wrote:
>> + /* Consider special static TLS alignment requirements. */
>> + static_tls_size = BFD_ALIGN (htab->tls_size, bed->static_tls_alignment);
>
> This won't work with the default of zero for static_tls_alignment.
Drats, must have been dreaming when I wrote that ;-( The easiest way
would be to use a default of 1 instead. Or, if we want to be extremely
clear
if (bed->static_tls_alignment == 0)
static_tls_size = htab->tls-size;
else
static_tls_size = BFD_ALIGN (htab->tls_size, bed->static_tls_alignment);
Which variant do you prefer?
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University