Re: [PATCH] gas: blackfin: reign in overeager insn flag handling

[Mike Frysinger <vapier at gentoo dot org>]

On Sunday, October 10, 2010 04:24:40 Mike Frysinger wrote:
> From: Steve Kilbane <steve.kilbane@analog.com>
> 
> Currently, trying to declare single letter variables in Blackfin assembly
> can sometimes lead to parser errors if that letter is used for insn flags.
> For example, X, Z, S, M, and T are used to change the behavior of insns:
> 	R0 = 1; R0 = 1 (X); R0 = 1 (Z);
> But the current parser just looks for single letter tokens rather than
> ones that show up in the (FLAGS) field.  So only match these letters as
> flags when they're in parentheses.
> 
> Not a complete fix, but it at least lets gcc tests pass now (the test
> gcc/testsuite/gcc.c-torture/compile/mangle-1.c to be exact).  A complete
> fix would require a significant parser rewrite in order to handle:
> 	R0 = (x) (x);	/* zero extend the address of the symbol "x" */
> 	R0 = W; R0 = W[P0];

committed
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.