Re: [PATCH] objcopy: add an interleave width parameter to objcopy

[Ben Gardiner <bengardiner at nanometrics dot ca>]

Hi Nick,

On Fri, Sep 10, 2010 at 8:16 AM, Nick Clifton <nickc@redhat.com> wrote:
> Thanks for submitting this enhancement. ?Normally we would requite a FSF
> Binutils copyright assignment before we could accept the code, but since the
> core of the change is so small, I have decided to accept it as an "obvious
> change".

I'm glad it found a home. Thank you for all the additional work you
performed to integrate these changes. It is above and beyond what you
had to do and it is greatly appreciated.

> I have checked your patch in with one change - I altered the name of the new
> option from --width to --interleave-width. ?I felt that --width on its own
> was too generic and might confuse people unfamiliar with the interleaving
> options to objcopy. ?I also took the trouble to reword the description of
> the interleaving switches in the binutils.texi file, as I felt that it was a
> little hard to understand in its former state.

I agree that --interleave-width is a better option name. I've also
read through your changes to the .texi file [1] and they look good to
me.

> I also created two changelog entries for your patch (see below). Normally
> these would be produced by you when you submit the patch.

I understand; I will make Changelog entries and FSF attributions with
future patches. Thank you again for putting the finishing touches on
this patch.

Best Regards,
Ben Gardiner

[1] http://sourceware.org/cgi-bin/cvsweb.cgi/src/binutils/doc/binutils.texi.diff?r1=1.170&r2=1.171&cvsroot=src&f=h

---
Nanometrics Inc.
http://www.nanometrics.ca