This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch pe-coff]: Fix output of debug sections in image
- From: Dave Korn <dave dot korn dot cygwin at gmail dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Binutils <binutils at sourceware dot org>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>, Kai Tietz <ktietz70 at googlemail dot com>, Richard Henderson <rth at redhat dot com>
- Date: Wed, 22 Sep 2010 12:59:51 +0100
- Subject: Re: [patch pe-coff]: Fix output of debug sections in image
- References: <OF7D15B989.421D37B2-ONC12577A6.002E9BEA-C12577A6.00348FBB@onevision.de>
On 22/09/2010 10:34, Kai Tietz wrote:
> Hmm, not sure what you mean here in the COFF_WITH_PE function. As far as I
> see my patch, I didn't touched that part. Also I see here in the
> non-COFF_WITH_PE no reason to add this is_dbg flag. What get I wrong here?
Err, nothing, I was looking at the wrong version of the function as you've
realised! So my comment about the strcmps is incorrect, please ignore it and
just go ahead with the remaining parts.
> Well, see here Alan's patch
>
> 2010-09-16 Alan Modra
[ ... snip ... ]
> By this I read that either a debugging section has not to set
> SEC_NEVER_LOAD on elf, as no output would be written then for it. So the
> combination of debugging and never-load is IMHO something what can just
> happen for pe-coff.
Thank you, that's just the sort of explanation I'd like you to put in a
comment; no need for any extra check, given the above. OK after that.
cheers,
DaveK