Re: [patch x64 SEH]: Sort pdata section ascending

[Dave Korn <dave dot korn dot cygwin at gmail dot com>]

On 14/09/2010 19:23, Richard Henderson wrote:
> On 09/14/2010 10:18 AM, Kai Tietz wrote:

>> +  bfd_vma vl, vr;
>> +  vl = bfd_getl32 (lp); vr = bfd_getl32 (rp);
>> +  if (vl != vr)
>> +    return (vl < vr ? -1 : 1);
>> +  vl = bfd_getl32 (lp + 4); vr = bfd_getl32 (rp + 4);
>> +  if (vl != vr)
>> +    return (vl < vr ? -1 : 1);
>> +  vl = bfd_getl32 (lp + 8); vr = bfd_getl32 (rp + 8);
>> +  if (vl != vr)
>> +    return (vl < vr ? -1 : 1);
>> +  return 0;
> 
> Isn't the start address the only thing that matters here?
> We really shouldn't have overlapping entries.  Certainly
> the pointer into the .xdata section should not be included
> in the sort order; that's totally irrelevant.

  BTW, are we OK with requiring GCC to build binutils, or is the code meant to
be ANSI compatible?  I can't remember where this is documented.

    cheers,
      DaveK