Re: [PATCH, COMMIT]: Avoid seg-fault when merging entries

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Fri, Aug 20, 2010 at 8:54 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Aug 20, 2010 at 8:30 AM, Nick Clifton <nickc@redhat.com> wrote:
>> Hi H.J.
>>
>>>> ? ?https://bugzilla.redhat.com/show_bug.cgi?id=623687
>>
>>> How come a section doesn't have an alignment?
>>
>> I did not actually get that far in investigating the problem.
>>
>>> Did you mean alignment 1?
>>
>> Yes. ?The code in sec_merge_emit() actually checks the alignment_power field
>> of the bfd_section structure, which would be zero for an alignment of 1.
>>
>>> Can we add a testcase?
>>
>> There is a testcase in the Fedora bug report (see the URL above). ?It should
>> be possible to covert this into a linker testcase. ?I'll look into it.
>>
>
> I tried the testcase with linker on Fedora 13 as well as yesterday's linker
> from CVS. I didn't see linker crash.
>

I have a feeling that the real bug is somewhere else and the patch may be
incorrect.  But it is hard for me to tell without a testcase I can reproduce.


-- 
H.J.