This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make --start-lib/--end-lib block on previous add symbols tasks


On Thu, Aug 19, 2010 at 3:19 PM, Ian Lance Taylor <iant@google.com> wrote:
> Neil Vachharajani <nvachhar@google.com> writes:
>
>> That was the way I originally implemented it :) ?But talking to Cary
>> we couldn't find a precedent of having two blockers for one task.
>
> I certainly hope that it works.

It works just fine.  Here's the new patch and ChangeLog

ChangeLog

        gold/
        * gold/archive.h (Add_lib_group_symbols): Add
readsyms_blocker_, adjust constructor, and set_blocker.
        * gold/archive.cc (Add_lib_group_symbols::is_runnable): Also
check readsyms_blocker_.
        * gold/readsyms.cc (Read_symbols::do_lib_group): Also pass
this->this_blocker_ to Add_lib_group_symbols::set_blocker.

>
> Ian
>



-- 
Neil Vachharajani
Google
650-214-1804

Attachment: gold_start_end_lib_patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]