This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS/LD: Fix up testsuite breakage from gettextisation
- From: Nick Clifton <nickc at redhat dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, binutils at sourceware dot org
- Date: Tue, 17 Aug 2010 10:50:47 +0100
- Subject: Re: [PATCH] MIPS/LD: Fix up testsuite breakage from gettextisation
- References: <alpine.DEB.1.10.1008170108000.4295@tp.orcam.me.uk>
Hi Maciej,
broke MIPS/LD testsuite, because (despite the innocent description) it
added semantic changes.
Sorry for that.
Here's the offending hunk:
- printf ("Hard float (-mdouble-float)\n");
+ printf (_("Hard float (double precision)\n"));
While the changes to the messages might have been legitimate (what was the
reason behind them BTW? -- I don't find the new ones any better than the
old ones),
The reason was that the output was referring to command line options
that are specific to GCC, which I felt was incompatible with readelf's
mission to work with any ELF binary, regardless of which compiler
produced it.
Here are the test case updates required unless we revert the semantic
changes above. Tested with mips-sde-elf and mips-linux-gnu targets.
Comments?
Approved - please apply.
If the change is to stay, then we may as well fix up the old ChangeLog
entry. I can do this while committing this testsuite update; at this
point it seems to make sense to do all of this with a single commit.
Agreed.
Cheers
Nick