This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA] [ARM] Fix Neon Alignment Syntax acceptance
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 28 Jun 2010 10:02:24 +0100
- Subject: Re: [RFA] [ARM] Fix Neon Alignment Syntax acceptance
- References: <1277475312.12570.28.camel@e102319-lin.cambridge.arm.com>
On Fri, 2010-06-25 at 15:15 +0100, Matthew Gretton-Dann wrote:
> All,
>
> Please can someone review, and approve the attached patch?
>
> Most Neon load/store instructions accept an optional alignment
> parameter. The current syntax accepted by gas requires a comma before
> the alignment parameter. However, this is not what was originally
> intended, and this patch corrects that. We still accept the current
> syntax as well.
>
> This means that the following are now both valid:
> VLD1.8 {d0}, [r1, :128]
> VLD1.8 {d0}, [r1 :128]
>
> We disassemble to the second form.
>
> Proposed ChangeLogs:
>
> gas/ChangeLog:
> 2010-06-25 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * config/tc-arm.c (parse_neon_alignment): New function.
> (parse_address_main): Fix Neon load/store alignment parsing.
>
>
> gas/testsuite/ChangeLog:
> 2010-06-25 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * gas/arm/neon-ldst-align-bad.l: Update for Neon alignment
> syntax fix.
> * gas/arm/neon-ldst-align-bad.s: Likewise.
> * gas/arm/neon-ldst-es.d: Likewise.
> * gas/arm/neon-ldst-es.s: Likewise.
>
> opcodes/ChangeLog:
> 2010-06-25 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * arm-disc.c (parse_insn_neon): Fix Neon alignment syntax.
OK
R.