This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch]: Improve readelf for ia64/OpenVMS
On Fri, Jun 11, 2010 at 8:59 AM, Tristan Gingold <gingold@adacore.com> wrote:
>
> On Jun 11, 2010, at 5:16 PM, Nick Clifton wrote:
>
>> Hi Tristan,
>>
>>> Thank you for the review. ?I have added your changes. ?Here is the new patch.
>>> The ChangeLog entries are the same, except for the typo pointed out by Hartmut.
>>
>> Great - patch approved - please apply.
>
> Thanks, just committed.
>
I checked in this to fix:
/net/gnu-6/export/gnu/src/binutils-hsw/binutils/binutils/readelf.c: In
function ‘dump_ia64_vms_dynamic_fixups’:
/net/gnu-6/export/gnu/src/binutils-hsw/binutils/binutils/readelf.c:5115:
warning: format ‘%lx’ expects type ‘long unsigned int’, but argument 2
has type ‘bfd_vma’
on 32bit hosts.
--
H.J.
--
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 72745ad..4eb958b 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2010-06-11 H.J. Lu <hongjiu.lu@intel.com>
+
+ * readelf.c (dump_ia64_vms_dynamic_fixups): Cast to unsigned long
+ for 0x%lx.
+
2010-06-11 Tristan Gingold <gingold@adacore.com>
Doug Rupp <rupp@gnat.com>
diff --git a/binutils/readelf.c b/binutils/readelf.c
index 757fefb..dc06078 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -5112,7 +5112,7 @@ dump_ia64_vms_dynamic_fixups (FILE *file, struct ia64_vms_
dynfixup *fixup,
else
{
warn ("corrupt library name index of 0x%lx found in dynamic entry",
- fixup->needed);
+ (unsigned long) fixup->needed);
lib_name = "???";
}
printf (_("\nImage fixups for needed library #%d: %s - ident: %lx\n"),