This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] ARM: Disassemble lsls #0 as movs in Thumb-1
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 02 Jun 2010 10:47:30 +0100
- Subject: Re: [PATCH] ARM: Disassemble lsls #0 as movs in Thumb-1
- References: <1275406141.22316.18.camel@e102319-lin.cambridge.arm.com>
On Tue, 2010-06-01 at 16:29 +0100, Matthew Gretton-Dann wrote:
> diff --git a/gas/testsuite/gas/arm/thumb.s
> b/gas/testsuite/gas/arm/thumb.s
> index d1e4339..79cadd7 100644
> --- a/gas/testsuite/gas/arm/thumb.s
> +++ b/gas/testsuite/gas/arm/thumb.s
> @@ -200,3 +200,7 @@ forwardonly:
> .target:
> nop @ pad for a.out
> nop
> +
> +baz:
> + mov r0, r1
> +
This bit isn't right: the nops that precede your new code are to pad the
object out to an even number of words (so that disassembly will be
consistent across all object formats).
Other than this, the patch is fine.
R.