This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Handle target specific relocatable relocation.
- From: Ian Lance Taylor <iant at google dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Mon, 24 May 2010 21:33:02 -0700
- Subject: Re: [PATCH][GOLD] Handle target specific relocatable relocation.
- References: <AANLkTinH38DlbPaGR5b66NcbySdfJMSAQjniRaHJH5ej@mail.gmail.com>
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> For reasons I do not understand, the hooks in Sized_target do not
> follow the normal convention in gold for virtual functions involving a
> public interface foo() and a protected implementation do_foo().
I haven't looked at your patch yet, but the reason for this is that
the Sized_target class is, by design, entirely abstract. All the
methods are virtual and they are all either pure or crash. There was
no need to separate the interface presented to others from the
interface supplied by the child class: Sized_target only has a child
class interface.
Ian