Re: gold patch for fixing ICF bugs.

[Ian Lance Taylor <iant at google dot com>]

Sriraman Tallam <tmsriram@google.com> writes:

> +		  long long offset = it_a->first;
> +
> +                  unsigned long long addend = it_a->second;
> +                  // Ignoring the addend when it is a negative value --
> +                  // this is taken from function 'Value' in file 'object.h'.
> +                  if (addend < 0xffffff00)
> +                    offset = offset + it_a->second;

You can just write offset += addend.

Probably the use of "long long" in icf.h and gc.h and here should
change to int64_t.  That is how most of gold deals with a large value.
That can be a separate change, though.


> +check_DATA += icf_virtual_function_folding_test.stdout

I don't see anything which creates this file.  I think you need to add
it.


This is OK with the above changes, plus Cary's suggestion.

Thanks.

Ian