This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [07/11] TI C6X binutils port: bfd/

From: DJ Delorie <dj at redhat dot com>
To: "Joseph S. Myers" <joseph at codesourcery dot com>
Cc: binutils at sourceware dot org
Date: Tue, 23 Mar 2010 20:37:25 -0400
Subject: Re: [07/11] TI C6X binutils port: bfd/
References: <Pine.LNX.4.64.1003230402050.30653@digraph.polyomino.org.uk> <Pine.LNX.4.64.1003230408230.30653@digraph.polyomino.org.uk>

+static reloc_howto_type elf32_tic6x_howto_table[] =
+{
+  HOWTO (R_C6000_NONE,		/* type */

Why not R_TIC6X_NONE ?  (although, most of the other TI ports don't
include the chip name at all)

+    { BFD_RELOC_C6000_NOCMP, R_C6000_NOCMP },
+  };

Please remove that last comma.

> Index: bfd/libbfd.h
> Index: bfd/reloc.c

These need the copyright years bumped.

Otherwise OK.

Follow-Ups:
- Re: [07/11] TI C6X binutils port: bfd/
  - From: Joseph S. Myers

References:
- [00/11] TI C6X binutils port: introduction
  - From: Joseph S. Myers
- [07/11] TI C6X binutils port: bfd/
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]