This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix ARM GAS segment fault

From: Jie Zhang <jie at codesourcery dot com>
To: binutils <binutils at sourceware dot org>
Date: Fri, 19 Mar 2010 22:46:38 +0800
Subject: Re: [PATCH] Fix ARM GAS segment fault
References: <4BA355EB.2040802@codesourcery.com> <20100319125507.GB11789@caradoc.them.org>

On 03/19/2010 08:55 PM, Daniel Jacobowitz wrote:

On Fri, Mar 19, 2010 at 06:46:03PM +0800, Jie Zhang wrote:
ARM GAS crashes on the following test case now:
nop
.fill 0, 0, 0
nop
This .fill directive does not generate anything. So the mapping
symbol "$d" generated for this .fill will have the same value as the
"$a" generated for the second "nop", which GAS does not allow.
To fix this case, this patch just allows two mapping symbols have the
same value and let the new one override the old one.
No regression on GAS testsuite. Is it OK?
OK.

Thanks. Committed. And I replaced the ChangeLog entry of the test with the one below.

	* gas/arm/mapmisc.s: Add the test case for two mapping
	  symbols having the same value.
	* gas/arm/mapmisc.d: Likewise.


--
Jie Zhang
CodeSourcery
(650) 331-3385 x735

References:
- [PATCH] Fix ARM GAS segment fault
  - From: Jie Zhang
- Re: [PATCH] Fix ARM GAS segment fault
  - From: Daniel Jacobowitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]