This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: Fix slow sparc relocation lookup

From: Nick Clifton <nickc at redhat dot com>
To: David Miller <davem at davemloft dot net>
Cc: binutils at sourceware dot org
Date: Tue, 02 Mar 2010 07:33:30 +0000
Subject: Re: [PATCH]: Fix slow sparc relocation lookup
References: <20100301.212420.16484222.davem@davemloft.net>

Hi David,

2010-03-01 David S. Miller<davem@davemloft.net>

	* elfxx-sparc.c (struct elf_reloc_map): Delete.
	(sparc_reloc_map): Delete.
	(_bfd_sparc_elf_reloc_type_lookup): Explicitly handle each
	relocation type in switch statements.

Approved - please apply - although I would recommend adding a comment explaining that the switch table is used for efficiency so that some future programmer does not decide to replace it with a lookup table and a loop...

Cheers
  Nick

Follow-Ups:
- Re: [PATCH]: Fix slow sparc relocation lookup
  - From: David Miller

References:
- [PATCH]: Fix slow sparc relocation lookup
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]