This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[RFA] Small fixes to ld-arm testsuite
- From: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- To: binutils at sourceware dot org
- Date: Tue, 23 Feb 2010 15:16:58 +0000
- Subject: [RFA] Small fixes to ld-arm testsuite
Hi,
Can I please have approval for the attached patch? This fixes up some
small failures in the ld-arm part of the ld testsuite.
Proposed ChangeLog:
2010-02-23 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* ld-arm/group-relocs.s: Mark code sections as executable.
* ld-arm/arm-elf.exp (armelftests): Only dump executable
sections in group-relocs test.
* ld-arm/reloc-boundaries.d: Fix test to work on Linux targets.
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer - Tools, PD Software
ARM Limited
Index: ld/testsuite/ld-arm/arm-elf.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/arm-elf.exp,v
retrieving revision 1.71
diff -u -p -r1.71 arm-elf.exp
--- ld/testsuite/ld-arm/arm-elf.exp 18 Feb 2010 10:56:28 -0000 1.71
+++ ld/testsuite/ld-arm/arm-elf.exp 23 Feb 2010 15:01:54 -0000
@@ -69,7 +69,7 @@ if { ![is_elf_format] || ![istarget "arm
set armelftests {
{"Group relocations" "-Ttext 0x8000 --section-start zero=0x0 --section-start alpha=0xeef0 --section-start beta=0xffeef0" "" {group-relocs.s}
- {{objdump -Dr group-relocs.d}}
+ {{objdump -dr group-relocs.d}}
"group-relocs"}
{"Thumb-1 BL" "-Ttext 0x1000 --section-start .foo=0x401000" "" {thumb1-bl.s}
{{objdump -dr thumb1-bl.d}}
Index: ld/testsuite/ld-arm/group-relocs.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/group-relocs.s,v
retrieving revision 1.1
diff -u -p -r1.1 group-relocs.s
--- ld/testsuite/ld-arm/group-relocs.s 15 Jun 2006 11:03:02 -0000 1.1
+++ ld/testsuite/ld-arm/group-relocs.s 23 Feb 2010 15:01:54 -0000
@@ -118,7 +118,7 @@ one_group_needed_ldc_pc:
@ We will place the section zero at 0x0.
- .section zero
+ .section zero, "x"
one_group_needed_alu_sb:
one_group_needed_ldr_sb:
@@ -128,7 +128,7 @@ one_group_needed_ldc_sb:
@ We will place the section alpha at 0xeef0.
- .section alpha
+ .section alpha, "x"
two_groups_needed_alu_sb:
two_groups_needed_ldr_sb:
@@ -142,7 +142,7 @@ two_groups_needed_ldc_pc:
@ We will place the section beta at 0xffeef0.
- .section beta
+ .section beta, "x"
three_groups_needed_alu_sb:
three_groups_needed_ldr_sb:
Index: ld/testsuite/ld-arm/reloc-boundaries.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-arm/reloc-boundaries.d,v
retrieving revision 1.1
diff -u -p -r1.1 reloc-boundaries.d
--- ld/testsuite/ld-arm/reloc-boundaries.d 28 Dec 2009 18:55:16 -0000 1.1
+++ ld/testsuite/ld-arm/reloc-boundaries.d 23 Feb 2010 15:01:54 -0000
@@ -2,5 +2,5 @@
[^:]*: file format elf32-(little|big)arm
Contents of section .text:
- 8000 80ff0080 ffff ......
+ 80.. 80ff0080 ffff ......
#...