This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] Update ARM attribute support for Tag_DIV_use and Tag_MPextension_use
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 17 Feb 2010 18:26:16 +0000
- Subject: Re: [Patch] Update ARM attribute support for Tag_DIV_use and Tag_MPextension_use
- References: <1266403898.2671.16.camel@e102111-lin.cambridge.arm.com>
This is ok.
You can commit it yourself once your account is activated.
R.
On Wed, 2010-02-17 at 10:51 +0000, Matthew Gretton-Dann wrote:
> Hi,
>
> Please can someone review, and then if appropriate approve, and commit
> the attached patch?
>
> The patch adds support for the ARM ABI attributes: Tag_DIV_use, and
> Tag_MPextension_use. It also adds some new attribute values for
> existing attributes to the attribute dumping in readelf.
>
> The interesting part of the patch is the support for
> Tag_MPextension_use. A previous version of the ABI gave this tag the ID
> 70, however, the latest version of the ABI has changed the ID to 42. To
> keep compatibility with old toolchains that use the old ID I treat both
> tag IDs as being identical - but when merging attributes we only output
> the new ID.
>
> ChangeLog entry:
> 2010-02-17 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
> * bfd/elf32-arm.c (elf32_arm_merge_eabi_attributes): Add support
> for merging Tag_DIV_use, Tag_MPextension_use, and
> Tag_MPextension_use_legacy tags.
> * bfd/readelf.c (arm_attr_tag_Advanced_SIMD_arch): Add
> description of newly permitted attribute values.
> (arm_attr_tag_Virtualization_use): Likewise.
> (arm_attr_tag_DIV_use): Add description of new attribute.
> (arm_attr_tag_MPextension_use): Likewise.
> * gas/config/tc-arm.c (arm_convert_symbolic_attribute): Add
> Tag_DIV_use.
> * gas/doc/c-arm.texi: Likewise
> * include/elf/arm.h (Tag_MPextension_use): Renumber.
> (Tag_DIV_use): Add.
> (Tag_MPextension_use_legacy): Likewise.
> * gas/testsuite/arm/attr-order.d: Fix test for new name for
> Tag_Virtualization_use attribute values
> * ld/testsuite/ld-arm/attr-merge-3.attr: Fix test for new
> Tag_MPextension_use value.
> * ld/testsuite/ld-arm/attr-merge-3b.s: Likewise
> * ld/testsuite/ld-arm/attr-merge-unknown-1.d: Fix test now that
> 42 is a recognised attribute ID.
> * ld/testsuite/ld-arm/attr-merge-unknown-1.s: Likewise.
> * ld/testsuite/ld-arm/attr-merge-6.attr: New test.
> * ld/testsuite/ld-arm/attr-merge-6a.s: Likewise.
> * ld/testsuite/ld-arm/attr-merge-6b.s: Likewise.
> * ld/testsuite/ld-arm/attr-merge-7.attr: Likewise.
> * ld/testsuite/ld-arm/attr-merge-7a.s: Likewise.
> * ld/testsuite/ld-arm/attr-merge-7b.s: Likewise.
> * ld/testsuite/ld-arm/arm-elf.exp: Run the new tests.
>
> Thanks,
>
> Matt