This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: GNU_STACK header is not present when linking with gc-sections.
- From: Ian Lance Taylor <iant at google dot com>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: binutils <binutils at sourceware dot org>
- Date: Thu, 14 Jan 2010 17:41:25 -0800
- Subject: Re: GNU_STACK header is not present when linking with gc-sections.
- References: <863b0cbf1001141644g71f401e7x6df39bcf324797cc@mail.gmail.com>
Sriraman Tallam <tmsriram@google.com> writes:
> Index: object.cc
> ===================================================================
> RCS file: /cvs/src/src/gold/object.cc,v
> retrieving revision 1.117
> diff -u -u -p -r1.117 object.cc
> --- object.cc 8 Jan 2010 22:34:34 -0000 1.117
> +++ object.cc 15 Jan 2010 00:34:15 -0000
> @@ -1321,7 +1321,7 @@ Sized_relobj<size, big_endian>::do_layou
> }
> }
>
> - if (!is_gc_pass_one)
> + if (!is_gc_pass_two)
> layout->layout_gnu_stack(seen_gnu_stack, gnu_stack_flags);
>
>
> Is this ok to submit ?
This is OK with a ChangeLog entry, if it fixes the problem.
Thanks.
Ian