Re: Binutils 2.20.1

[Ian Lance Taylor <iant at google dot com>]

Matthias Klose <doko@ubuntu.com> writes:

> are any gold updates planned for 2.20.1? For a rebuild test with gold
> as the default linker I would like to see a fix for 11072 on the
> branch (objcopy --add-gnu-debuglink is used a lot for package
> building). Other missing features/options are summarized by Peter
> Fritzsche in [1].

Since you asked, I have committed the patch for PR 11072 to the
binutils 2.20 branch.

I believe that all the options mentioned in Peter Fritzsche's Debian
bug report are now supported in the mainline version of gold.  But I'm
a little reluctant to simply copy mainline into the 2.20 branch as
they have had very little testing.  I was willing to risk total
breakage for 2.20.0 but I don't want 2.20.1 to be worse than 2.20.0.


> is there a chance that the --enable-gold= patch is approved for the
> trunk and backported to the branch?

I think this patch is still pending approval by a binutils maintainer.

Ian


11072 patch committed to 2.20 branch:


2010-01-13  Ian Lance Taylor  <iant@google.com>

	Bring over from mainline:
	2010-01-08  Ian Lance Taylor  <iant@google.com>

	PR 11072
	* layout.cc (Layout::include_section): Remove .gnu_debuglink
	sections.


Index: layout.cc
===================================================================
RCS file: /cvs/src/src/gold/layout.cc,v
retrieving revision 1.134.2.3
diff -p -u -r1.134.2.3 layout.cc
--- layout.cc	5 Nov 2009 06:25:01 -0000	1.134.2.3
+++ layout.cc	13 Jan 2010 15:36:13 -0000
@@ -1,6 +1,6 @@
 // layout.cc -- lay out output file sections for gold
 
-// Copyright 2006, 2007, 2008, 2009 Free Software Foundation, Inc.
+// Copyright 2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.
 // Written by Ian Lance Taylor <iant@google.com>.
 
 // This file is part of gold.
@@ -349,6 +349,11 @@ Layout::include_section(Sized_relobj<siz
           if (is_prefix_of(".gnu.lto_", name))
             return false;
         }
+      // The GNU linker strips .gnu_debuglink sections, so we do too.
+      // This is a feature used to keep debugging information in
+      // separate files.
+      if (strcmp(name, ".gnu_debuglink") == 0)
+	return false;
       return true;
 
     default: