This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD][PATCH] Added support for R_ARM_V4BX relocation
- From: =?big5?b?RG91ZyBLd2FuICjD9q62vHcp?= <dougkwan at google dot com>
- To: Viktor Kutuzov <vkutuzov at accesssoftek dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 11 Jan 2010 16:54:49 -0800
- Subject: Re: [GOLD][PATCH] Added support for R_ARM_V4BX relocation
- References: <6AE1604EE3EC5F4296C096518C6B77EE01884D4372@mail.accesssoftek.com>
I cannot approve but I have some comments. The sort of works but I am
not sure if we want it to be always enabled. Can you add
ld-compatible command line switches at least to turn this on and off?
Adding interworking support is not difficult as all the
infrastructures are in place. If I were you, I would create a new sub
class V4bx_stub of the Stub class to represent the v4bx stubs. You
need to add one new stub template as far as I can see. I would also
add a vector in Stub_table to hold these V4bx_stub since there are
only a small fixed number of possible stubs The stub table class
already handles both relocation stubs and cortex-A8 stub. So it is
quite straight forward to add another support stub type. You can look
at arm_branch_common to see how we redirect a branch to a stub.
-Doug
2010/1/11 Viktor Kutuzov <vkutuzov@accesssoftek.com>:
> Hello everyone,
>
> Please find attached a patch that adds a support for R_ARM_V4BX relocation.
>
> It supports the instruction replacement only, no interworking yet.
> The interworking for R_ARM_V4BX is to be discussed.
>
> Best regards,
> Viktor
>
> * gold/arm.cc: Added support for R_ARM_V4BX relocation