This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Objcopy: use a hash table for symbol renaming


On Fri, 18 Dec 2009, Eirik Byrkjeflot Anonsen wrote:
> The attached patch replaces the linked list with a hash table
> implementation.

As just a random binutils target maintainer, I'd say: Thanks!

But... is there a good reason to add a new hash table
implementation instead of re-using the one in libiberty/hashtab.c?
(Besides, missing ChangeLog entry and required FSF assignment,
which I guess you'll hear more about from someone else.)

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]