This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][patch] Move the reader and writer classes to incremental.h
- From: Cary Coutant <ccoutant at google dot com>
- To: Rafael Espindola <espindola at google dot com>
- Cc: Binutils <binutils at sourceware dot org>, Ian Lance Taylor <iant at google dot com>, Mikolaj Zalewski <mikolajz at google dot com>
- Date: Wed, 2 Dec 2009 13:19:19 -0800
- Subject: Re: [gold][patch] Move the reader and writer classes to incremental.h
- References: <38a0d8450912021300m1659c4fdqdf883e2fb6ff174a@mail.gmail.com>
Patch?
> To use the reader classes in incremental-dump.cc I have to move them
> to the .h file. IMHO it looks more natural to move the writer too.
> ...
> ? ? ? ?* incremental.h (Incremental_inputs_header)
> ? ? ? ?(Incremental_inputs_header_write, Incremental_inputs_entry,
> ? ? ? ?Incremental_inputs_entry_write): Move ...
> ? ? ? ?* incremental.cc (Incremental_inputs_header)
> ? ? ? ?(Incremental_inputs_header_write, Incremental_inputs_entry,
> ? ? ? ?Incremental_inputs_entry_write): here.
Is this backwards? Aren't you moving them from the .cc file to the .h file?
-cary