This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH, libiberty: eliminate build warning

From: Ian Lance Taylor <iant at google dot com>
To: Ben Elliston <bje at au1 dot ibm dot com>
Cc: binutils <binutils at sourceware dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>, dj at redhat dot com
Date: Sun, 22 Nov 2009 20:01:57 -0800
Subject: Re: PATCH, libiberty: eliminate build warning
References: <1258625975.11150.8.camel@bapbop> <mcrk4xl95et.fsf@dhcp-172-17-9-151.mtv.corp.google.com> <1258933752.18264.22.camel@bapbop>

Ben Elliston <bje@au1.ibm.com> writes:

> -#define writeerr(s) (void) write (STDERR_FILE_NO, s, strlen (s))
> +  int retval = 0;
> +#define writeerr(s) retval |= write (STDERR_FILE_NO, s, strlen (s))

It seems to me that it should be
  #define writeerr(s) retval |= write (STDERR_FILE_NO, s, strlen (s)) < 0

This is OK with that change if it makes sense to you.

Ian

References:
- PATCH, libiberty: eliminate build warning
  - From: Ben Elliston
- Re: PATCH, libiberty: eliminate build warning
  - From: Ian Lance Taylor
- Re: PATCH, libiberty: eliminate build warning
  - From: Ben Elliston

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]