This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add bfd_target_info function to bfd and unify windres/windmc target information gathering


2009/11/14 Dave Korn <dave.korn.cygwin@googlemail.com>:
> Kai Tietz wrote:
>> Dave,
>>
>> thanks, here is updated version.
>
> ?You still missed one superfluous space:
>
>> ?const bfd_target *bfd_find_target (const char *target_name, bfd *abfd);
>>
>> +const bfd_target * bfd_get_target_info (const char *target_name,
> ? ? ? ? ? ? ? ? ? ? ^
> ?The asterisk always goes hard up against the symbol, because that's how it
> binds (the canonical example being "char* x,y;" vs. "char *x,y;"). ?Everything
> else looked good.
>
> ? ?cheers,
> ? ? ?DaveK
>

Ah, the prototype in comment, which gets exported into bfd-in2.h I've missed.

Here is updated patch.

Ok for apply?

Cheers,
Kai

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination

Attachment: bfd_target_info.diff
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]