This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix build error on OSX


On Nov 6, 2009, at 7:15 AM, Alan Modra wrote:

On Fri, Nov 06, 2009 at 01:47:57PM +0900, Masaki Muranaka wrote:
Why are you concluding I didn't test? ;-) 

Your patch sets -Werror in CFLAGS.  How can setting -Werror avoid an
error caused by -Werror?

I think this is a wrong patch for a real issue.
autoconf tests wether stat64 is usable but even with --enable-werror, it didn't check that warnings are
generated.
As a consequence, compilation of strings.c fails.

Adding unconditionally -Werror is wrong because this should at least be handled with --enable-werror.
Looks like there is something to do within autoconf but I am not an expert at all in it.

My two cents,
Tristan.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]