This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][GOLD] Add -z nocopyreloc option.
- From: Ian Lance Taylor <iant at google dot com>
- To: Doug Kwan (éæå) <dougkwan at google dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 30 Sep 2009 16:53:25 -0700
- Subject: Re: [PATCH][GOLD] Add -z nocopyreloc option.
- References: <498552560909301633m9ead633v9cf1a4b711fe862a@mail.gmail.com>
"Doug Kwan (éæå)" <dougkwan@google.com> writes:
> This patch added a -z nocopyreloc option for compatiblity with ld.
> Tested on x86_64 with no regression.
Please instead add an option -z copyreloc, with an appropriate
nohelpstring argument. You will get the option -z nocopyreloc for
free. That will make the option easier to understand in the code.
Also please take the opportunity to stamp out some duplication. Move
may_need_copy_reloc to be a Symbol function. Change everything except
ARM to just call that function. Change ARM to use
arm_may_need_copy_reloc which can call that and also check for
STT_ARM_TFUNC.
Thanks.
Ian