This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Binutils branch 2.20 (done!)
Hi Alan,
Alan Modra wrote:
On Fri, Sep 04, 2009 at 12:00:55PM +0200, Tristan Gingold wrote:
I have just created the 2.20 branch and updated the version on HEAD.
I will try to do the first prerelease soon.
Lots of testsuite failures at the moment. It would be nice if target
maintainers would give these some attention.
bfin-elf/log0:FAIL: flow2
bfin-elf/log0:FAIL: loop
bfin-elf/log0:FAIL: loop2
bfin-elf/log0:FAIL: loop3
I don't see these 4 FAILs here.
bfin-elf/log0:FAIL: ld-elf/64ksec-r
bfin-elf/log0:FAIL: ld-elf/64ksec
These two FAIL is because Blackfin as does not accept "SYMBOL = VALUE".
Blackfin has an algebra assembly syntax. Assigning value to a register
has the form:
"REG = VALUE"
If there is typo of REG, this will become "SYMBOL = VALUE". That error
is not easy to notice. So I think it's better to let Blackfin gas reject
"SYMBOL = VALUE" to detect such error. .set can be used if user want to
set value to a symbol.
How about the attached patch?
Jie
gas/
* doc/as.texinfo: Document that Blackfin GAS does not
accept SYMBOL = VALUE.
ld/testsuite/
* ld-elf/sec64k.exp: Use .set instead of = to assign
value to symbol.
Index: gas/doc/as.texinfo
===================================================================
RCS file: /cvs/src/src/gas/doc/as.texinfo,v
retrieving revision 1.208
diff -u -r1.208 as.texinfo
--- gas/doc/as.texinfo 4 Sep 2009 02:31:44 -0000 1.208
+++ gas/doc/as.texinfo 5 Sep 2009 12:33:06 -0000
@@ -3272,6 +3272,13 @@
equals sign @samp{=}@samp{=} here represents an equivalent of the
@code{.eqv} directive. @xref{Eqv,,@code{.eqv}}.
+Blackfin has an algebra assembly syntax.
+Assigning value to a register has the form @code{REG = VALUE}.
+If there is typo of @code{REG}, this will become @code{SYMBOL = VALUE}.
+That error is not easy to notice. So it's better to let Blackfin GAS
+reject @code{SYMBOL = VALUE} to detect such error.
+@code{.set} can be used if user want to set value to a symbol.
+
@node Symbol Names
@section Symbol Names
Index: ld/testsuite/ld-elf/sec64k.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elf/sec64k.exp,v
retrieving revision 1.16
diff -u -r1.16 sec64k.exp
--- ld/testsuite/ld-elf/sec64k.exp 2 Sep 2009 07:25:39 -0000 1.16
+++ ld/testsuite/ld-elf/sec64k.exp 5 Sep 2009 12:33:07 -0000
@@ -77,9 +77,9 @@
puts $ofd "bar_\\secn:"
puts $ofd " .dc.a bar_\\secn"
puts $ofd " .endm"
- puts $ofd " secn = [expr $i * $secs_per_file]"
+ puts $ofd " .set secn, [expr $i * $secs_per_file]"
puts $ofd " .rept $secs_per_file"
- puts $ofd " secn = secn + 1"
+ puts $ofd " .set secn, secn + 1"
puts $ofd " sec %(secn), %(secn-1)"
puts $ofd " .endr"