This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix Thumb-2 shared libraries
- From: Daniel Jacobowitz <drow at false dot org>
- To: Christophe LYON <christophe dot lyon at st dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 26 Aug 2009 10:35:42 -0400
- Subject: Re: Fix Thumb-2 shared libraries
- References: <20090612140642.GA31950@caradoc.them.org> <4A32626C.8090407@st.com> <4A3658C4.3000800@st.com> <20090615175935.GA22200@caradoc.them.org> <4A390CF5.3000505@st.com> <20090617162337.GA9315@caradoc.them.org> <4A3A4DEF.5070704@st.com> <4A3A4E62.8030603@st.com> <20090825185158.GA2712@caradoc.them.org> <4A94F9FB.9070407@st.com>
On Wed, Aug 26, 2009 at 11:01:47AM +0200, Christophe LYON wrote:
> On 25.08.2009 20:51, Daniel Jacobowitz wrote:
> > Unfortunately, this patch breaks Thumb-2 shared libraries.
> Would you mind giving an example?
Sure. I built glibc as a Thumb-2 binary. Because we change the type
of function symbols, calloc was marked as an ARM mode entry point in
ld.so's dynamic symbol table. When ld.so resolves its own
relocations, it filled in an ARM-mode address in the PLT GOT. So the
first call to calloc from ld.so caused us to execute Thumb code in ARM
mode.
> >Here's a patch I'm testing for this failure.
> It seems OK, but I think you forgot to add a test case :-)
I think your testcase serves nicely - now that I've fixed it to test
for correct behavior :-)
I'm going to wait for another internal test run before I commit this,
but it looks good so far.
--
Daniel Jacobowitz
CodeSourcery