This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Committed: Fix seg fault in COFF/PE based ARM GAS


Hi Guys,

  I am applying the patch below as an obvious fix for the COFF/PE
  targeted ports of GAS to the ARM architecture.  The lack of the test
  for a NULL seh_ctx_root was causing lots of segmentation faults when
  running the testsuites for these targets.

Cheers
  Nick

gas/ChangeLog
2009-08-26  Nick Clifton  <nickc@redhat.com>

	* config/obj-coff-seh.c (seh_arm_write_pdata): Test for
	seh_ctx_root being NULL.

Index: gas/config/obj-coff-seh.c
===================================================================
RCS file: /cvs/src/src/gas/config/obj-coff-seh.c,v
retrieving revision 1.3
diff -c -3 -p -r1.3 obj-coff-seh.c
*** gas/config/obj-coff-seh.c	18 Aug 2009 17:50:12 -0000	1.3
--- gas/config/obj-coff-seh.c	26 Aug 2009 08:19:35 -0000
*************** seh_arm_write_pdata (void)
*** 209,215 ****
    bfd *abfd = stdoutput;
  
    h = seh_ctx_root;
!   if (h->done)
      return;
    while (h != NULL)
      {
--- 209,215 ----
    bfd *abfd = stdoutput;
  
    h = seh_ctx_root;
!   if (h == NULL || h->done)
      return;
    while (h != NULL)
      {


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]