This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Committed: skip empty-address-3a and empty-address-3b for MMIX
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: binutils at sourceware dot org
- Date: Wed, 29 Jul 2009 20:22:58 -0400 (EDT)
- Subject: Committed: skip empty-address-3a and empty-address-3b for MMIX
The mmo object format does not have symbol sections, so for the
purpose of BFD, one is derived from the value and the address range of
the .text and .data sections (mmo doesn't really have sections either,
but that's another story). The heuristic for the symbol section type
includes symbols just after the section (at address+length) as
belonging to the section, which when specified in a linker script,
actually depends on whether the symbol was defined before or after the
closing "}" of the output-section specification. This goes wrong for
empty-address-3a and empty-address-3b (__data_end A becomes T).
Though these tests seem to primarily test the value, not the section
type, I think adjusting the expected section would tamper with the
integrity of the tests, so I'm just skipping them for
mmix-knuth-mmixware. (There's precedence for relaxing the section
type in empty-address-1 and empty-address-3c, but only for symbols in
removed sections; not for symbols intended for the absolute section.)
To wit, this patch gets rid of the following fails:
Running /home/hp/binutils/src/ld/testsuite/ld-scripts/empty-address.exp ...
FAIL: ld-scripts/empty-address-3a
FAIL: ld-scripts/empty-address-3b
Committed.
* ld-scripts/empty-address-3a.d, ld-scripts/empty-address-3b.d:
Skip for mmix-knuth-mmixware.
Index: ld-scripts/empty-address-3a.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/empty-address-3a.d,v
retrieving revision 1.1
diff -p -u -r1.1 empty-address-3a.d
--- ld-scripts/empty-address-3a.d 27 Sep 2006 04:18:16 -0000 1.1
+++ ld-scripts/empty-address-3a.d 30 Jul 2009 00:07:02 -0000
@@ -1,6 +1,7 @@
#source: empty-address-3.s
#ld: -T empty-address-3a.t
#nm: -n
+#notarget: mmix-knuth-mmixware
#...
0+0 T _start
#...
Index: ld-scripts/empty-address-3b.d
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-scripts/empty-address-3b.d,v
retrieving revision 1.1
diff -p -u -r1.1 empty-address-3b.d
--- ld-scripts/empty-address-3b.d 27 Sep 2006 04:18:16 -0000 1.1
+++ ld-scripts/empty-address-3b.d 30 Jul 2009 00:07:02 -0000
@@ -1,6 +1,7 @@
#source: empty-address-3.s
#ld: -T empty-address-3b.t
#nm: -n
+#notarget: mmix-knuth-mmixware
#...
0+0 T _start
#...
brgds, H-P