This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch testsuite ld]: Various fixes for the x86_64 pe target
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Kai Tietz <Kai dot Tietz at onevision dot com>
- Cc: Binutils <binutils at sourceware dot org>, Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Date: Thu, 25 Jun 2009 15:38:05 +0100
- Subject: Re: [patch testsuite ld]: Various fixes for the x86_64 pe target
- References: <OFAD206700.ECF97E86-ONC12575E0.004B533D-C12575E0.004C097D@onevision.de>
Kai Tietz wrote:
> while running the testsuite I found some new issues for the
> x86_64-*-mingw32 target and prepared a small patch to fix them (plus some
> old one, too).
Please when sending a patch don't use an imprecise description like "some
new issues", at least a quick summary of the problem(s) would make it more
immediately obvious how the patch solves it/them and save on requests for
clarification.
> * ld-pe/aligncomm-1.c (size_t): Add type.
"type" -> "typedef" please.
> (main): use it for casting pointer to scalar.
Missing capitalisation.
> * ld-pe/aligncomm-2.c: Likewise.
> * ld-pe/aligncomm-3.c: Likewise.
> * ld-pe/aligncomm-4.c: Likewise.
> * ld-scripts/empty-address.exp: Make sure that for x86_64-*-mingw*
> target imagebase is set to zero.
> * ld-scripts/weak.exp: Don't fail for x86_64-*-mingw* target.
>
> Regression tested for i686-pc-mingw32 and x86_64-pc-mingw32. Ok for apply?
OK, but do please explain what's going on in the aligncomm patches. Are you
getting a signedness or precision-loss warning that you want to fix?
cheers,
DaveK