This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] VAX/ELF: Store all call-saved registers upon PLT stub entry
- From: Nick Clifton <nickc at redhat dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: binutils at sourceware dot org, Jan-Benedict Glaw <jbglaw at lug-owl dot de>, linux-vax at pergamentum dot com
- Date: Mon, 15 Jun 2009 14:53:34 +0100
- Subject: Re: [PATCH] VAX/ELF: Store all call-saved registers upon PLT stub entry
- References: <alpine.LFD.1.10.0906030146020.2246@ftp.linux-mips.org>
Hi Maciej,
The current approach in BFD seems to be #1 above and I would like to get
it changed to the #2. Given the issues with the VAX/ELF backend I'm not
sure if the PLT stubs have already been used in actual software, raising
binary compatibility concerns. If so, I would limit this change to Linux
(regrettably creating an incompatible ELF flavour), otherwise I suggest it
to be applied universally.
Comments?
I think that your idea is good. Since nobody else has commented on the
issue of VAX PLT stubs, I would guess that they are not currently being
used elsewhere and so it would be safe for you to make this change
without worrying about backwards compatibility. Hence:
> bfd/
> 2009-06-04 Maciej W. Rozycki <macro@linux-mips.org>
>
> * elf32-vax.c (elf_vax_plt_entry): Set the entry mask to
> include <R11:R2>.
Approved - please apply.
Cheers
Nick