This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch i386 pe]: Allow multilib version gas for i386 pe-coff

H.J. Lu wrote:

> --- gas/config/obj-coff.h.foo	2007-10-30 11:48:38.000000000 -0700
> +++ gas/config/obj-coff.h	2009-05-19 15:03:51.000000000 -0700
> @@ -61,16 +61,6 @@
>  #include "coff/i386.h"
>  #endif
>  
> -#ifdef TE_PE
> -#ifdef TE_PEP
> -extern const char *i386_target_format (void);
> -#define TARGET_FORMAT i386_target_format ()
> -#define COFF_TARGET_FORMAT "pe-x86-64"
> -#else
> -#define TARGET_FORMAT "pe-i386"
> -#endif
> -#endif
> -
>  #ifndef TARGET_FORMAT
>  #ifdef TE_PEP
>  #define TARGET_FORMAT "coff-x86-64"

  Since this breaks a pattern (of having cpu-dependent TARGET_FORMAT
definition in obj-coff.h), perhaps we should leave a comment behind in place
of this deletion, explaining where it went and why.

    cheers,
      DaveK
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]