This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch i386 pe]: Allow multilib version gas for i386 pe-coff
On Tue, May 19, 2009 at 10:02 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> 2009/5/19 Dave Korn <dave.korn.cygwin@googlemail.com>:
>> Dave Korn wrote:
>>
>>> Kai, I'm OK with the patch once you've done that.
>>
>> ?Sorry, should have been more precise. ?I do think you should rebuild and
>> retest those four targets you mentioned, with this change, just to ensure we
>> don't run into any hidden problems with header include order or anything like
>> that.
>>
>> ? ?cheers,
>> ? ? ?DaveK
>>
>>
>
> Hmm, I am not that sure if the move of just this code into tc-i386.h
> is ok. For what reason how ever pe targets are defining their
> TARGET_FORMAT tag within obj-coff.h. Well I can move, but I expect
> here issues and then the rest of the defines should be moved out here,
> too. Possibly I don't see here the obvious, but I want to remark this.
>
I think TARGET_FORMAT is target specific. I don't think it should
affect non-x86 targets. If it does, we can fix it when we find it.
--
H.J.