This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve objdump -S performance


> I think this will return incorrect results.  Given a file with more
> than one function in a section, won't you stay stuck returning the
> lowest function symbol when disassembling the section?

The if (c->symbol.value >= cached_low_func && c->symbol.value <= offset)
test takes care of that.
I'm also careful to invalidate when the symbol could be reused.

I verified it by disassembling all the files in a Linux build
both with old and new objdump and it gives the same output.

-Andi


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]