This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR6744 (--export-dynamic not supported on PE)


Nick Clifton wrote:
> Hi Dave,
> 
>> ld/ChangeLog
>>
>>     PR ld/6744
>>     * ld.texinfo (--export-dynamic):  Mention --export-all-symbols.
>>     * emultempl/pe.em (gld_${EMULATION_NAME}_after_parse):  Issue
>>     warning if --export-dynamic was passed on command-line.
>>     * emultempl/pep.em (gld_${EMULATION_NAME}_after_parse):  Likewise.
>>
>> ld/testsuite/ChangeLog
>>
>>     PR ld/6744
>>     * ld-pe/export_dynamic_warning.d:  New test control file.
>>     * ld-pe/export_dynamic_warning.s:  New test source file.
>>     * ld-pe/pe.exp:  Also run export_dynamic_warning dump test.
> 
> Approved - please apply.

  Applied with one slight alteration: I added a target selector to the .d file

#target: *-*-mingw32 *-*-cygwin *-*-pe

  I'm just verifying that it does indeed pass on a bunch of the small embedded
ARM/MCORE/WinCE PE targets, I'll fix any fallout but don't expect it.  (If
anyone wants, I could patch the BeOS target to do this warning as well.  I
think that's the only PE target that uses a different emulation.)

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]