This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] fix dcbt operand order for "server" category
On Thu, Feb 05, 2009 at 05:30:21PM -0600, Peter Bergner wrote:
> On Thu, 2009-02-05 at 17:14 -0600, Peter Bergner wrote:
> > On Fri, 2009-02-06 at 08:30 +1030, Alan Modra wrote:
> > > On Thu, Feb 05, 2009 at 02:29:54PM -0600, Peter Bergner wrote:
> > > > The dcbt instruction that supports the TH operand used to be optional but
> > > > now is part of the base ISA. However, Embdedded and Server categories use
> > > > different operand ordering, with Embedded having TH being the first operand
> > > > and Server having TH being the last/3rd operand. Ditto for dcbtst.
> > >
> > > Horrible. This patch will break the linux kernel, won't it?
> >
> > Or were you worried that I was changing the binary bit pattern with
> > this change? All I'm trying to do is change the asm syntax accepted,
> > not the bit pattern we produce... Hmmm, looking at the hex bits in
> > the objdumps, something looks wrong (ie, they're not matching).
> > Let me check into that and report back.
>
> Actually, it was just a luser error on my part, using the wrong asm
> syntax with the wrong assembler options. I've confirmed that I get
> the same exact bit patterns either way.
Review error on my part. I thought you were swapping RA and RB too.
Patch OK.
--
Alan Modra
Australia Development Lab, IBM