This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] fix dcbt operand order for "server" category
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Andrew Pinski <pinskia at gmail dot com>
- Date: Thu, 05 Feb 2009 17:14:04 -0600
- Subject: Re: [PATCH] fix dcbt operand order for "server" category
- References: <1233865794.11684.36.camel@otta> <20090205220018.GA9332@bubble.grove.modra.org>
On Fri, 2009-02-06 at 08:30 +1030, Alan Modra wrote:
> On Thu, Feb 05, 2009 at 02:29:54PM -0600, Peter Bergner wrote:
> > The dcbt instruction that supports the TH operand used to be optional but
> > now is part of the base ISA. However, Embdedded and Server categories use
> > different operand ordering, with Embedded having TH being the first operand
> > and Server having TH being the last/3rd operand. Ditto for dcbtst.
>
> Horrible. This patch will break the linux kernel, won't it?
Or were you worried that I was changing the binary bit pattern with
this change? All I'm trying to do is change the asm syntax accepted,
not the bit pattern we produce... Hmmm, looking at the hex bits in
the objdumps, something looks wrong (ie, they're not matching).
Let me check into that and report back.
Peter