This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Add new INSN_* into mips.h

From: Nick Clifton <nickc at redhat dot com>
To: Eric Fisher <joefoxreal at gmail dot com>
Cc: binutils at sourceware dot org
Date: Tue, 06 Jan 2009 15:33:57 +0000
Subject: Re: Add new INSN_* into mips.h
References: <d6afecde0812242224s3f7b6d11rdd5417a2268084d5@mail.gmail.com> <d6afecde0812292200n2dede51bt8c9d910ce6fde2c1@mail.gmail.com>

Hi Eric.

I was hoping that a MIPS person would answer this, but ...

I have two solutions for this problem. One is to add a new field
"membership2" into struct mips_opcode, just like what "pinfo2" does.

Another way is to change the "membership" field from bit collection to
a function address. So mips_builtin_opcodes will look like this,

Personally I would go with whichever method is the least intrusive, and hence the least likely to generate new bugs. To me this sounds like your first suggestion - the second membership mask.

Cheers
  Nick

Follow-Ups:
- Re: Add new INSN_* into mips.h
  - From: Eric Christopher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]