This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch] Add --identify option to dlltool
On Fri, Nov 14, 2008 at 11:12:01PM -0500, Charles Wilson wrote:
>Kai Tietz wrote:
>>> I guess there are two choices:
>>>
>>> 1) ignore it. Only return "the first" .idata$7 entry.
>>
>> IMHO case 1) is that one to choose. Maybe it would be even better to check
>> if there is just one .idata$7 section present, and if not to reject it at
>> all.
>
>I decided it would be best to report only the first DLL name, but
>continue searching through the archive. If there are more than one
>assoicated dll names, then treat that as an error.
>
>Revised patch attached, now with comments and documentation!
A very minor comment: Most of the error messages in dlltool do not end
in period but you've added a couple that do. Could you nuke the
periods?
Other than that highly important observation, I think this looks good.
cgf