This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Fix valgrind nm complaint: memcpy to == from
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 13 Nov 2008 13:46:47 +1030
- Subject: Re: Fix valgrind nm complaint: memcpy to == from
- References: <200811130257.mAD2vXUb011550@ignucius.se.axis.com>
On Thu, Nov 13, 2008 at 03:57:33AM +0100, Hans-Peter Nilsson wrote:
> While this and the other calls in ld.log were simple to == from
> cases and could avoid the call to memcpy at all, it seems the
> code is intended to also have partial overlapping to and from,
No, we'll never have partial overlaps. size is that of one symbol.
> so it's memmove, not memcpy that should be used. No regressions
> for the binutils testsuite, fixes the valgrind nm complaints.
I think it's better to use
if (to != from)
memcpy (to, from, size);
if for no other reason than memmove will lead people to think there
may be partial overlaps. ;-)
--
Alan Modra
Australia Development Lab, IBM