This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] gas: Fix assembly listing on Windows.

From: DJ Delorie <dj at redhat dot com>
To: "Danny Smith" <dansmister at gmail dot com>, "Kazu Hirata" <kazu at codesourcery dot com>
Cc: binutils at sourceware dot org
Date: Fri, 03 Oct 2008 15:31:36 -0400
Subject: Re: [patch] gas: Fix assembly listing on Windows.
References: <20081003152840.159626F620B4@daisy.codesourcery.com> <9c03c2dd0810031205h41a9dfc2m9749c1256110003c@mail.gmail.com>

"Danny Smith" <dansmister@gmail.com> writes:
>> Kazu Hirata
>>
>> 2008-10-03  Kazu Hirata  <kazu@codesourcery.com>
>>
>>        * listing.c (buffer_line): Open the source file with FOPEN_RB.
>>        Manually process line ends.
>>
>
> This makes sense to me, especially since gcc outputs  assembler files
> in binary mode.

I have the same patch in my local tree (except without the '\r'
support), just hadn't gotten around to submitting it.  Patch approved.

References:
- [patch] gas: Fix assembly listing on Windows.
  - From: Kazu Hirata
- Re: [patch] gas: Fix assembly listing on Windows.
  - From: Danny Smith

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]