This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: i386 and x86_64 TLSDESC relocations to local symbols broken in gold
On Sep 13, 2008, Ian Lance Taylor <iant@google.com> wrote:
> If you can correct the comment in front of the function, that would be
> nice.
Oh, doh, I checked the patch in after making all the other fixes, then
realized I'd failed to make this one. Sorry.
I'm going ahead and checking in this one too.
for gold/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>
* i386.cc (Target_i386::define_tls_base_symbol): Update comments.
* x86_64.cc (Target_x86_64::define_tls_base_symbol): Likewise.
Index: gold/i386.cc
===================================================================
--- gold/i386.cc.orig 2008-09-16 01:29:42.000000000 -0300
+++ gold/i386.cc 2008-09-16 01:29:44.000000000 -0300
@@ -323,7 +323,7 @@ class Target_i386 : public Sized_target<
void
make_plt_entry(Symbol_table*, Layout*, Symbol*);
- // Define the _TLS_MODULE_BASE_ symbol at the end of the TLS segment.
+ // Define the _TLS_MODULE_BASE_ symbol in the TLS segment.
void
define_tls_base_symbol(Symbol_table*, Layout*);
@@ -736,7 +736,7 @@ Target_i386::make_plt_entry(Symbol_table
this->plt_->add_entry(gsym);
}
-// Define the _TLS_MODULE_BASE_ symbol at the end of the TLS segment.
+// Define the _TLS_MODULE_BASE_ symbol in the TLS segment.
void
Target_i386::define_tls_base_symbol(Symbol_table* symtab, Layout* layout)
Index: gold/x86_64.cc
===================================================================
--- gold/x86_64.cc.orig 2008-09-16 01:29:42.000000000 -0300
+++ gold/x86_64.cc 2008-09-16 01:29:44.000000000 -0300
@@ -330,7 +330,7 @@ class Target_x86_64 : public Sized_targe
void
make_plt_entry(Symbol_table*, Layout*, Symbol*);
- // Define the _TLS_MODULE_BASE_ symbol at the end of the TLS segment.
+ // Define the _TLS_MODULE_BASE_ symbol in the TLS segment.
void
define_tls_base_symbol(Symbol_table*, Layout*);
@@ -796,7 +796,7 @@ Target_x86_64::make_plt_entry(Symbol_tab
this->plt_->add_entry(gsym);
}
-// Define the _TLS_MODULE_BASE_ symbol at the end of the TLS segment.
+// Define the _TLS_MODULE_BASE_ symbol in the TLS segment.
void
Target_x86_64::define_tls_base_symbol(Symbol_table* symtab, Layout* layout)
--
Alexandre Oliva http://www.lsd.ic.unicamp.br/~oliva/
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}
FSFLA Board Member ÂSÃ Libre! => http://www.fsfla.org/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}