This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 3/5] Don't sort the MIPS symbol table in size_dynamic_sections
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sourceware dot org, rdsandiford at googlemail dot com
- Date: Wed, 6 Aug 2008 16:26:29 -0400
- Subject: Re: [PATCH 3/5] Don't sort the MIPS symbol table in size_dynamic_sections
- References: <87wsk9zevl.fsf@firetop.home>
On Sat, Jun 28, 2008 at 05:46:38PM +0100, Richard Sandiford wrote:
> bfd/
> * elfxx-mips.c (count_section_dynsyms): Move before the new first use.
> (mips_elf_sort_hash_table): Take the output bfd as a parameter.
> Remove the MAX_LOCAL parameter. Exit early if there are no
> dynamic symbols, if there is no dynobj, or if there is no
> GOT section. Use count_section_dynsyms instead of MAX_LOCAL.
> Assert == rather than <= when checking hsd.max_unref_got_dynindx.
> Also assert that g->global_gotno is right.
> (mips_elf_count_forced_local_got_symbols): Rename to...
> (mips_elf_count_got_symbols): ...and count global GOT entries too.
> Set the global_got_area of a forced-local GGA_RELOC_ONLY symbol
> to GGA_NONE.
> (mips_elf_multi_got): Don't sort the symbol table.
> (mips_elf_lay_out_got): Likewise. Use mips_elf_count_got_symbols
> to count the number of global GOT entries.
> (_bfd_mips_elf_final_link): Unconditionally call
> mips_elf_sort_hash_table.
OK.
--
Daniel Jacobowitz
CodeSourcery