This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: H' hex constants


Hi DJ,

How about this? It requires the target to enable the code at compile
time, and the user to enable it at runtime. A sample target change
for m32c is included. It's a simple patch (good) that's harmless
unless invoked (also good) and works as expected in the normal use
case (good).

Approved, providing that it does not introduce any regressions (both for the m32c and an x86 native).


It doesn't gracefully handle syntax errors though (bad),
but I suspect it's no worse than the surprise the user gets when they
use H'00 without this patch.  Perhaps an additional warning for single
quotes following symbol chars would be useful?

Yes that might be helpful.


Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]