This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] CR16 target specific fix

From: Nick Clifton <nickc at redhat dot com>
To: M R Swami Reddy <MR dot Swami dot Reddy at nsc dot com>
Cc: binutils at sourceware dot org
Date: Tue, 20 May 2008 16:55:13 +0100
Subject: Re: [PATCH] CR16 target specific fix
References: <4832B7F6.4040902@nsc.com>

Hi Swami,

      {
        mask = build_mask ();
+       /* Adjust mask for bcond with 32-bit size instruction.  */
+       if ((IS_INSN_MNEMONIC("b") && instruction->size == 2))
+         mask = 0xff0f0000;
+

Wouldn't it be better cleaner if this code was inside build_mask() ?

Cheers
  Nick

Follow-Ups:
- Re: [PATCH] CR16 target specific fix
  - From: M R Swami Reddy

References:
- [PATCH] CR16 target specific fix
  - From: M R Swami Reddy

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]