This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Ping version 2 of the MIPS soft-float patch
- From: Eric Christopher <echristo at apple dot com>
- To: Adam Nemet <anemet at caviumnetworks dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 28 Apr 2008 08:30:39 -0700
- Subject: Re: Ping version 2 of the MIPS soft-float patch
- References: <18453.60266.699827.622007@localhost.localdomain>
On Apr 28, 2008, at 8:21 AM, Adam Nemet wrote:
http://sourceware.org/ml/binutils/2008-04/msg00349.html
I'd been waiting for Richard to comment since he had last time, but...
Couple of comments:
Can you comment this struct with the field locations please?
static struct mips_set_options mips_opts = {
- ISA_UNKNOWN, -1, -1, 0, -1, -1, -1, -1, 0, ATREG, 0, 0, 0, 0, 0, 0,
CPU_UNKNOWN, FALSE
+ ISA_UNKNOWN, -1, -1, 0, -1, -1, -1, -1, 0, ATREG, 0, 0, 0, 0, 0, 0,
+ CPU_UNKNOWN, FALSE, FALSE, FALSE };
and the general flow here, i.e. what's going on. It's fairly obvious
but a comment would be nice.
+ if (mo->pinfo == INSN_MACRO)
Otherwise OK.
-eric