Re: [PATCH][SH] Ensure that offset alignments are valid

[Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>]

Andrew STUBBS <andrew.stubbs@st.com> wrote:
> OK, I'm working on it.

Thanks!

> With relaxation:
> 
> The old behaviour was a successful operation with no diagnostics, so 
> this clearly does need fixing.
> 
> $ ./as-new too_large.s -big -isa=sh4a -relax
> too_large.s: Assembler messages:
> too_large.s:25: Error: offset to unaligned destination
> too_large.s:32: Error: offset to unaligned destination
> too_large.s:39: Error: offset to unaligned destination
> 
> 
> I'm not sure what the proper way to fix this issue should be. I'm going 
> to keep looking into it, but do you have any clues?

I have no clue too.

> I never saw this problem before because the compiler does not (usually?) 
> produce PC-relative code with far destinations, and anyway relaxation is 
> broken elsewhere, I think.

I agree with you.  It would not be worth to effort to fix this
for the relax case at this time.

Regards,
	kaz